Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Fix Android deploy failures #7112

Merged
merged 2 commits into from
Jan 10, 2022
Merged

[No QA] Fix Android deploy failures #7112

merged 2 commits into from
Jan 10, 2022

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Jan 10, 2022

Details

This PR removes a deprecated package that is causing Android deploy failures. More context in #7111 (comment).

Fixed Issues

$ #7111

Tests

  1. Run the tests from [No QA] Performance tracking with flipper-plugin-performance #4760, confirm you can still see the performance options (see screenshots)
  2. Confirm you can run the app on all platforms
  3. From the App directory, run npm run build-android and confirm there is no error for Could not find com.facebook.flipper:flipper-noop:0.66.0.
  • Verify that no errors appear in the JS console

QA Steps

None, I'll confirm CPing this change results in a successful Android build

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

image
image

@Jag96 Jag96 self-assigned this Jan 10, 2022
@Jag96 Jag96 requested a review from a team as a code owner January 10, 2022 22:00
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from ctkochan22 and removed request for a team January 10, 2022 22:01
@Jag96
Copy link
Contributor Author

Jag96 commented Jan 10, 2022

Going to put this on HOLD since we have another issue where the iOS deploy is failing

@Jag96 Jag96 changed the title [No QA] Fix Android deploy failures [HOLD] Fix Android deploy failures Jan 10, 2022
@Jag96 Jag96 changed the title [HOLD] Fix Android deploy failures [No QA] Fix Android deploy failures Jan 10, 2022
@Jag96
Copy link
Contributor Author

Jag96 commented Jan 10, 2022

Taking off hold, this is ready for review

luacmartins
luacmartins approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming here to help with reviewing and QA since this blocks deploy. Changes LGTM and I confirmed that the apps run and the android build works. However, I had to follow these instructions to get the build.

@roryabraham
Copy link
Contributor

Okay, I'm having some issues creating an android build locally, but I don't want to be a roadblock. Two approvals is enough for me to think we'll be okay to live-test this with a staging deploy.

@roryabraham roryabraham merged commit c8e312b into main Jan 10, 2022
@roryabraham roryabraham deleted the joe-fix-android-build branch January 10, 2022 23:54
OSBotify pushed a commit that referenced this pull request Jan 10, 2022
@roryabraham @OSBotify
Merge pull request #7112 from Expensify/joe-fix-android-build
def78f4 
(cherry picked from commit c8e312b)
This was referenced Jan 10, 2022
Merged
Closed
@Jag96
Copy link
Contributor Author

Jag96 commented Jan 11, 2022

Android deploy was successful 🎉 https://github.com/Expensify/App/runs/4768966594?check_suite_focus=true

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @roryabraham in version: 1.1.27-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@roryabraham roryabraham mentioned this pull request Jan 12, 2022
Closed
54 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.27-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@roryabraham
Copy link
Contributor

No double-deploy-comment here 🎉

@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctkochan22 ctkochan22 ctkochan22 approved these changes

@luacmartins luacmartins luacmartins approved these changes

@roryabraham roryabraham Awaiting requested review from roryabraham

Assignees

@Jag96 Jag96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jag96 @roryabraham @OSBotify @ctkochan22 @luacmartins